Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cadiback dependency #482

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gussmith23
Copy link

@gussmith23 gussmith23 commented Apr 23, 2024

Feel free to make whatever edits you want to this -- was my quick solution to the problem.

Closes #481.

@gussmith23
Copy link
Author

@aytey would love help on this. Unsure why CI is failing. This was the minimal set of changes to get it to work on my side, but I'm sure there's more that's needed!

@aytey
Copy link
Member

aytey commented Apr 24, 2024

@aytey would love help on this. Unsure why CI is failing. This was the minimal set of changes to get it to work on my side, but I'm sure there's more that's needed!

I'll try to look on Friday -- sorry.

As a note, I'm not sure if appveyor has been happy "in quite a while", so it failing might be something to ignore.

@aytey
Copy link
Member

aytey commented Apr 24, 2024

I just approved the CI for gcc/clang -- sorry for not doing that sooner.

@gussmith23
Copy link
Author

Unsure why clang passed and gcc failed. I expected both to fail. gcc-built version getting errors like this:

/home/runner/work/stp/stp/build/tests/unit-tests/MergeSame_TestTests: error while loading shared libraries: libcadiback.so: cannot open shared object file: No such file or directory

This is because deps/cadiback/libcadiback.so and deps/cadical/build/libcadical.so need to be installed alongside STP. Currently, I don't think that's happening. I'm not quite sure what the right way is to make that happen with CMake. I'm assuming it's a simple fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CryptoMiniSat build script needs updating
2 participants