Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firing an action with the info addon is slower than molasses #1535

Closed
levithomason opened this issue Jul 28, 2017 · 3 comments
Closed

Firing an action with the info addon is slower than molasses #1535

levithomason opened this issue Jul 28, 2017 · 3 comments

Comments

@levithomason
Copy link

What is this?

A button with onClick={action('onClick')}. Two identical stories except the first is added with .add() the second with .addWithInfo().

What I'm doing

馃槃 Clicking the button several times in the add() story. The actions are logged immediately.

馃槥 Clicking the button once in the addWithInfo() story. The UI freezes for several seconds before the action is logged.

Demo

http://g.recordit.co/QNxUJm0trG.gif

In all fairness, it is probably slightly faster than molasses, depending.

@shilman
Copy link
Member

shilman commented Jul 28, 2017

In v4 we will deprecate the addWithInfo API and rename it to addWithMolasses. 馃槶

In all seriousness, we're making a bunch of changes to the info addon (e.g. #1147) so let's see how things shake out with that. cc @usulpro

@stale
Copy link

stale bot commented Nov 23, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Nov 23, 2017
@stale
Copy link

stale bot commented Dec 8, 2017

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants