Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Needs to be reverted #442

Open
espkk opened this issue Nov 27, 2022 · 1 comment
Open

Needs to be reverted #442

espkk opened this issue Nov 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@espkk
Copy link
Member

espkk commented Nov 27, 2022

7877868
This causes quite noticeable performance regression and should be reverted somehow
@espkk espkk added the bug Something isn't working label Nov 27, 2022
@espkk
Copy link
Member Author

espkk commented Nov 27, 2022

context:
making copy of FuncInfo (on each event call) triggers copying of vector of LocalVarInfo that leads to multiple heavy allocations on each frame
I workarounded that on my local branch by putting LocalVarInfo into std::shared_ptr, but I'm not satisfied with this approach

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@espkk