Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance bottleneck: too small chunks from uplink_download_read #21

Open
Erikvv opened this issue Nov 24, 2022 · 4 comments
Open

Performance bottleneck: too small chunks from uplink_download_read #21

Erikvv opened this issue Nov 24, 2022 · 4 comments
Labels
enhancement New feature or request Need Estimation

Comments

@Erikvv
Copy link
Contributor

Erikvv commented Nov 24, 2022

When calling uplink_download_read() it only gives back 7408 bytes. I've tested this with current main branch.

For some languages/platforms there is a big overhead calling native functions and the large number of calls becomes a performance bottleneck.

@ifraixedes ifraixedes added the enhancement New feature or request label Nov 25, 2022
@Erikvv
Copy link
Contributor Author

Erikvv commented Nov 29, 2022

Jeff: seems like that should be easy to fix with a call to https://pkg.go.dev/io#ReadFull (or something similar) and some careful error handling..

@kmozurkewich
Copy link

Do we know where the 7408 value coming from?

@Erikvv
Copy link
Contributor Author

Erikvv commented Jan 9, 2023

@wthorp
Copy link
Contributor

wthorp commented Jan 10, 2023

It looks like this was previously created as an issue but possibly not fully diagnosed before closing storj/storj#3499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Need Estimation
Projects
Status: Backlog
Development

No branches or pull requests

5 participants