Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to perform in-memory encoding on upload #36

Open
amwolff opened this issue Oct 5, 2021 · 1 comment
Open

Provide an option to perform in-memory encoding on upload #36

amwolff opened this issue Oct 5, 2021 · 1 comment
Labels
edge enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up for grabs

Comments

@amwolff
Copy link
Member

amwolff commented Oct 5, 2021

We added the hacktoberfest label to issues we considered a good fit for 2021's Hacktoberfest. If you want to work on this issue, let us know in the discussion below, so we can remove the up for grabs label and avoid having people working on the same issue independently, making sure no one's work goes in vain. Please also consider discussing how you would like to approach the problem, if appropriate. Thank you for contributing!


The uplink library that Gateway-MT and Gateway-ST use internally has an option to perform file encoding (upload) with an in-memory buffer instead of a disk buffer. The type of buffer should be a config option for both gateways. Currently, only Gateway-MT uses it:

  1. pkg/server/middleware/inmemory.go
  2. cmd/gateway-mt/main.go#L45

It would be best to port this feature into Gateway-ST as well. The context value that tells libuplink to perform in-memory encoding can be set in Gateway-ST's object layer directly for Put... functions. Since Gateway-MT imports Gateway-ST, this functionality can be essentially moved from Gateway-MT to here and re-imported.

@amwolff
Copy link
Member Author

amwolff commented Feb 14, 2024

oh, oops, shouldn't have closed it

@amwolff amwolff reopened this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edge enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up for grabs
Projects
None yet
Development

No branches or pull requests

1 participant