Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internals to work with async-interop loop spec #69

Open
staabm opened this issue Dec 30, 2016 · 3 comments
Open

Refactor internals to work with async-interop loop spec #69

staabm opened this issue Dec 30, 2016 · 3 comments

Comments

@staabm
Copy link
Member

staabm commented Dec 30, 2016

Factor out our internal stream_select based event-loop according to the async-interop spec[1] to make the stomp client play well with compatible concurrency frameworks (e.g. amphp, reactphp,..).

We need to figure out which default loop we use, in case our stomp lib is used standalone. We can either default to the impl we already have, or e.g. Use the amphp based event loop (which is per default also based on stream_select - when not high perf ev/uv php-extensions are available)

[1] https://github.com/async-interop/event-loop

@jmglsn
Copy link
Member

jmglsn commented Dec 31, 2016

I like the idea to update our lib to rely on https://github.com/async-interop/event-loop. I was attending a talk from @clue this year in Hamburg and I really would like to see our lib working on reactphp.

@jmglsn
Copy link
Member

jmglsn commented Oct 17, 2017

Let's create another repository and start a version that is designed for react-php.
We could start with some requirements, what do you think?

@staabm
Copy link
Member Author

staabm commented Oct 17, 2017

Yeah lets prototype it in a separate repos at first.

I would go with amp instead of react though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants