Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isConnected() returning true, ignoring the credentials #162

Open
Norgul opened this issue Aug 4, 2021 · 0 comments
Open

isConnected() returning true, ignoring the credentials #162

Norgul opened this issue Aug 4, 2021 · 0 comments

Comments

@Norgul
Copy link

Norgul commented Aug 4, 2021

Having the following code:

$client = new Client($connectionWrapper->connection);
$client->setLogin($username, $password);

$connected = $client->connect();

Will return false only in cases when URL is unreachable or the port is wrong. As long as URL:port is accessible, it will return true independently of credentials provided, which seems kinda wrong.

@Norgul Norgul changed the title isConnected() returning true independently of credentials isConnected() returning true, ignoring the credentials Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant