Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken connection is not detected #150

Open
brajnacs opened this issue Oct 26, 2020 · 1 comment
Open

Broken connection is not detected #150

brajnacs opened this issue Oct 26, 2020 · 1 comment
Assignees

Comments

@brajnacs
Copy link

brajnacs commented Oct 26, 2020

Hi There,

I am facing a problem where the library doesn't tell if a connection is broken. I found a similar issue here #104. In the end of the thread, Its mentioned that it's fixed in 4.4.0 and looking at the file at that version, this is indeed the case. Look at the following line

if ($read === '' || $read === false) {

See the blank data check? but in newer versions (I checked in 4.6.1) this line is again reverted back and its creating the same issue again.

If that was intentional, can someone please point me to the right direction so that I can detect the broken connections? Any help will be appreciated.

Thank you guys.

@jmglsn
Copy link
Member

jmglsn commented Jan 15, 2021

Hi @brajnacs,
that broken connection detection is only working with heartbeats, otherwise (with that check in place) we also fail if the connection is still ok.
Did you check heartbeats already?
BR
Jens

@jmglsn jmglsn self-assigned this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants