Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for comma delimiter #14

Open
lowryrussell opened this issue Apr 5, 2021 · 1 comment
Open

Support for comma delimiter #14

lowryrussell opened this issue Apr 5, 2021 · 1 comment

Comments

@lowryrussell
Copy link

Awesome library. Could definitely put this to use. Do you plan to add support for comma delimiters for thousand, millions, etc.? (e.g 1,000.00 or 1,000,000.00)

@stokatyan
Copy link
Owner

That's a really good idea, I wish I realized it during development. As of now I have no plans to update the project unless there is some iOS update that breaks the project. If I end up updating ScrollCounter to support a new iOS, then I'll look into comma delimiters. In the meantime, I'm happy to review a PR if you want to give it a shot :)

Thanks for checking out the ScrollCounter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants