Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nitpicks #78

Open
2 of 11 tasks
newAM opened this issue Aug 3, 2021 · 0 comments
Open
2 of 11 tasks

Nitpicks #78

newAM opened this issue Aug 3, 2021 · 0 comments
Assignees
@newAM
Labels
enhancement New feature or request

Comments

@newAM
Copy link
Member

newAM commented Aug 3, 2021 •
edited

  • Replace wall-of-text # Safety sections with enumerated check-lists of requirements.
  • Lots of duplicated code across testsuites (fixed in testsuite: deduplicate code #82)
  • Provide a from_millis, from_nanos, from_secs ect. with subghz::Timeout
  • Normalize meta-access of peripherals for all peripherals (maybe trait these to enforce uniformity?)
    • pub unsafe fn steal() -> Self
    • fn mask_irq()
    • pub unsafe fn unmask_irq()
    • pub unsafe fn pulse_reset(rcc: &mut pac::RCC)
    • pub fn enable_clock(rcc: &mut pac::RCC)
    • pub unsafe fn disable_clock(rcc: &mut pac::RCC)
    • Normalize what new does with regards to clocks, resets, enables, and interrupts
@newAM newAM self-assigned this Aug 3, 2021
@newAM newAM added the enhancement New feature or request label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@newAM newAM

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@newAM