You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NotMask: [1, "Date/day don’t care in Alarm comparison"]
In my opinion, value 0 should have NotMasked variant, and value 1 should have Masked, which is also aligned with NVIC concept: set unmask then some function activate, set mask then some function deactivate.
Or even better, I suggest to use
"MSK1": Alarm seconds maskToMatch: [0, "Alarm set if the date/day match"] NotCare: [1, "Seconds don’t care in Alarm comparison"]
to make this values more clearly.
But this modification will break current api, so maybe we need more discussion on it?
and also, MSK1 ~ MSK4 share the same description, which is not correct, and need to be too.
The text was updated successfully, but these errors were encountered:
eZioPan
changed the title
[Discussion] variant name of MSK* are misleading
[Discussion] variant names of MSK* are misleading
Apr 7, 2023
stm32-rs/peripherals/rtc/rtc_common.yaml
Lines 158 to 160 in 371fc81
In my opinion, value
0
should haveNotMasked
variant, and value1
should haveMasked
, which is also aligned with NVIC concept: setunmask
then some function activate, setmask
then some function deactivate.Or even better, I suggest to use
to make this values more clearly.
But this modification will break current api, so maybe we need more discussion on it?
and also,
MSK1
~MSK4
share the same description, which is not correct, and need to be too.The text was updated successfully, but these errors were encountered: