Skip to content
This repository has been archived by the owner on Sep 9, 2019. It is now read-only.

ReportSheet-Klasse auseinanderpflücken #147

Open
andyundso opened this issue Jan 4, 2019 · 1 comment
Open

ReportSheet-Klasse auseinanderpflücken #147

andyundso opened this issue Jan 4, 2019 · 1 comment
Assignees
@andyundso
Labels
infrastructure
Projects
iZivi Improvement Board

Comments

@andyundso
Copy link
Member

Die ReportSheet-Klasse ist ein riesiges Durcheinander, ein Teil dient zur Generierung der Spesenblätter, ein anderer Teil dient zur Berechnung der Diensttage.

Beide Sachen können in eigene Service-Klassen ausgelagert werden, sodass sich diese Klasse wirklich nur noch dem Datenbank-Model widmet. Die Berechnung der Diensttage und deren neue Lösung wird im Rahmen von #78 bereits angeschaut.
@andyundso andyundso added this to Ideen in iZivi Improvement Board via automation Jan 4, 2019
@andyundso andyundso moved this from Ideen to Backlog in iZivi Improvement Board Jan 4, 2019
@andyundso
Copy link
Member Author

andyundso commented Jan 14, 2019 •
edited

Nachfragen bei Marc:

  • Die Anzeige der Ferien-Kommentare (zu Ferien aufgrund Betriebsferien und persönlichen Ziviferien) wurde in teils Fällen gar nie im PDF gerendert. Soll dies behoben werden?

@andyundso andyundso self-assigned this Jan 14, 2019
andyundso added a commit that referenced this issue Jan 16, 2019
@andyundso
Removed "getSpesen" method [#147]
4ee250e 
Most of the work happened in the previous commits by refactoring a lot of views and controller methods.
andyundso added a commit that referenced this issue Jan 17, 2019
@andyundso
Moved adding of new ReportSheets when Mission changes into Controller […
f6efb66 
…#147]
andyundso added a commit that referenced this issue Jan 17, 2019
@andyundso
Replaced legacy MissionDaysCalculator with new ones
e83741c 
Related to #147 as well as #78.
@TheFehr TheFehr moved this from Backlog to Erledigt in iZivi Improvement Board Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andyundso andyundso

Labels
infrastructure
Projects
iZivi Improvement Board
Erledigt
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andyundso