Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed usage of area code values #167

Open
dmyers opened this issue May 3, 2024 · 2 comments
Open

Mixed usage of area code values #167

dmyers opened this issue May 3, 2024 · 2 comments

Comments

@dmyers
Copy link

dmyers commented May 3, 2024

It seems the area code is implemented differently in several drivers. Some drivers are returning the region/state such as CA and some are returning real area codes like phone numbers such as 555.

I think this makes it difficult to implement and rely on this attribute with the fallback functionality. Imagine inserting data with the area code and having different values in a database, it would result in a lot of bugs and cases needing to account for these differences. Is there a way maybe some of these non numeric drivers could just set their values to null?

Are there any other things like this that might be good to outline in the readme?

@stevebauman
Copy link
Owner

Hi @dmyers,

Are you able to identify which drivers are returning different data for area code? The driver name should be included in the Position object returned via the Location::get() method.

@dmyers
Copy link
Author

dmyers commented May 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants