Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embrace the color / focus / hover / disabled guidelines from Photon or Material Design #244

Closed
stephanrauh opened this issue Mar 29, 2020 · 1 comment
Closed

Embrace the color / focus / hover / disabled guidelines from Photon or Material Design #244

stephanrauh opened this issue Mar 29, 2020 · 1 comment
Assignees
@stephanrauh
Labels
enhancement New feature or request Solved

Comments

@stephanrauh
Copy link
Owner

The Photon UI guidelines of Firefox should match the look and feel of the PDF viewer nicely. Let's try to adopt them. Also see mozilla/pdf.js#11758 (comment).

Among other things, this means the background color of the toolbars should be rgba(12, 12, 13, 0.8) on light themes and rgba(249, 249, 250, 0.8) on dark themes, as stated in https://design.firefox.com/photon/visuals/color.html.

https://design.firefox.com/photon/components/buttons.html
https://design.firefox.com/photon/components/input-fields.html
https://design.firefox.com/photon/components/checkboxes.html

image

image

image

image
@stephanrauh stephanrauh self-assigned this Mar 30, 2020
@stephanrauh stephanrauh mentioned this issue Jul 14, 2020
Closed
stephanrauh added a commit that referenced this issue Sep 13, 2020
@stephanrauh
#435 improved encapsulation of the CSS code; #244 started to add colo…
e79b3c6 
…r themes
stephanrauh added a commit that referenced this issue Sep 17, 2020
@stephanrauh
#435 improved encapsulation of the CSS code; #244 started to add colo…
22f9d18 
…r themes; implement early versions of the simplified dark and the light theme; #469 added support for the Perfect Scrollbar plugin
stephanrauh added a commit that referenced this issue Sep 17, 2020
@stephanrauh
#244 started to add color themes; implement early versions of the sim…
04429cb 
…plified dark and the light theme
stephanrauh added a commit that referenced this issue Sep 19, 2020
@stephanrauh
#244 fine-tuning the toolbar of the sidebar
8ef1121
stephanrauh added a commit that referenced this issue Sep 19, 2020
@stephanrauh
#244 remove the horizontal separators because they didn't take the pr…
cbea4e9 
…ogrammatic visibility setting into account
stephanrauh added a commit that referenced this issue Sep 19, 2020
@stephanrauh
#457 updating to pdf.js 2.6.384 (form support); #244 improving the li…
a3b2658 
…ght theme
stephanrauh added a commit that referenced this issue Sep 19, 2020
@stephanrauh
#457 updating to pdf.js 2.6.384 (form support); #244 improving the li…
ad19903 
…ght theme
stephanrauh added a commit that referenced this issue Sep 22, 2020
@stephanrauh
#244 improved support for older browsers
0f131e9
stephanrauh added a commit that referenced this issue Sep 23, 2020
@stephanrauh
#244 use SVG icons supporting every color theme
93da0b7
@stephanrauh
Copy link
Owner Author

The new color theme ships with version 5.0 of the viewer. Maybe it's not exactly the photon theme, but it's good enough.

@stephanrauh stephanrauh added enhancement New feature or request Solved labels Sep 27, 2020
stephanrauh added a commit that referenced this issue Sep 27, 2020
@stephanrauh
#244 use SVG icons supporting every color theme
0cd9d10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanrauh stephanrauh

Labels
enhancement New feature or request Solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephanrauh