Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Context and public methods either open or turn them into a protocol. #200

Open
kaygro opened this issue Feb 18, 2018 · 2 comments
Open

Comments

@kaygro
Copy link

kaygro commented Feb 18, 2018

This would enable more substantial extensions, without people bothering you about modifications, which aren't really relevant to your project goals. It might also be a good thing to open up the default tags in a similar fashion.

@mrackwitz
Copy link
Contributor

I like this idea, as I happen to need a lazy context at the moment.
Either way this will enlarge the public API and so add burden from a maintainers perspective. Subclassing isn't quite en vogue with Swift and tends to be harder to get right. I'd tend towards protocols, if it doesn't complicate things too much.
@kylef @AliSoftware @ilyapuchka: Any opinions on that? I'd be open to tackle this.
Also open for alternatives, if you have ideas.

@AliSoftware
Copy link
Collaborator

\cc @djbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants