Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide first-class Windows support for the CLI #1274

Open
janewang opened this issue Mar 26, 2024 · 2 comments
Open

Provide first-class Windows support for the CLI #1274

janewang opened this issue Mar 26, 2024 · 2 comments
Assignees

Comments

@janewang
Copy link
Contributor

janewang commented Mar 26, 2024

We'd like to build a robust testing infrastructure for different Operating Systems (including windows) and provide the same level of support for Windows CLI users as other OSs. Where possible, we need to include Windows as a standard part of our testing infrastructure.

Given powershell is now available out of box in newer version of windows, we're going to align docs to powershell (not cmd).

@chadoh chadoh changed the title Provide first-class window support for the CLI Provide first-class Windows support for the CLI Apr 2, 2024
@willemneal
Copy link
Member

@janewang @fnando @leighmcculloch
Adding this here: https://blog.rust-lang.org/2024/04/09/cve-2024-24576.html

One exception though is cmd.exe (used among other things to execute batch files), which has its own argument splitting logic. That forces the standard library to implement custom escaping for arguments passed to batch files. Unfortunately it was reported that our escaping logic was not thorough enough, and it was possible to pass malicious arguments that would result in arbitrary shell execution.

I don't think this is an issue for our use of Command. However, we should look into our deps and update rust version.

All Rust versions before 1.77.2 on Windows are affected, if your code or one of your dependencies executes batch files with untrusted arguments. Other platforms or other uses on Windows are not affected.

@janewang
Copy link
Contributor Author

janewang commented May 14, 2024

Remaining --alias and contract init (fix initialize.js, which right is *nix only).

#1248

When ^ is done, we can fix the last article that needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants