Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there TypeScript typings for this project? #304

Open
devaskim opened this issue Sep 27, 2022 · 6 comments
Open

Are there TypeScript typings for this project? #304

devaskim opened this issue Sep 27, 2022 · 6 comments

Comments

@devaskim
Copy link

I am going to use this awesome project to extend capabilities of map widget implemented in Thingsboard IoT platform. The UI of the platform is Angular project, so there is Typescript.
My question is: where I can find TypeScript typings?

@stefanocudini
Copy link
Owner

leaflet was not written in typescript

@devaskim
Copy link
Author

devaskim commented Oct 24, 2022

@stefanocudini Sorry, but not a serious answer.
Leaflet has official typings or type definitions to use it in Typescript-ed project.

@stefanocudini
Copy link
Owner

stefanocudini commented Oct 24, 2022

@stefanocudini Sorry, but not a serious answer. Leaflet has official typings or type definitions to use it in Typescript-ed project.

may be it's official for github.com/DefinitelyTyped not for Leaflet organization..

@devaskim
Copy link
Author

@stefanocudini Thanks for your time but our discussion is out of scope of original question. I think you agree with me.

Let's start from the beginning

  1. Do you have plans to add Typescripts type definitions for your plugin?
  2. Here is unofficial attempt to create type definitions, but that was a long time ago and I could success with it.

I'm not an experienced Typescript developer to do such job so I decided to ask for help there.

@stefanocudini
Copy link
Owner

  1. Do you have plans to add Typescripts type definitions for your plugin?
    no
  1. Here is unofficial attempt to create type definitions, but that was a long time ago and I could success with it.

it sounds interesting but I don't know Typescripts and I have no idea how this works, however the types for the options all seem right:
https://github.com/bastisk/leaflet-search-types/blob/master/index.d.ts#L5

@stefanocudini
Copy link
Owner

stefanocudini commented Oct 24, 2022

I leave the issue open if anyone TP dev wants to contribute with a PR

@stefanocudini stefanocudini reopened this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants