Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18px border between client area and right window edge #23

Closed
atraczyk opened this issue Jan 10, 2024 · 8 comments
Closed

18px border between client area and right window edge #23

atraczyk opened this issue Jan 10, 2024 · 8 comments
Assignees
Labels
bug Something isn't working fixed

Comments

@atraczyk
Copy link

image

Platform: seems to only occur on Windows 10 (22H2-19045.3803) and with ENABLE_WINDOWS_SYSTEM_BORDERS off
Steps to reproduce:

  • I get it on application start with built-in and minimal examples

Note: resizing the app will correct the sizing issue, moving it again will reintroduce it.

Accepting the WM_MOVE event in WindowsNativeEventFilter::nativeEventFilter seems to prevent this from occurring, but I have no idea why or what side effects it introduces.

@SineStriker
Copy link
Contributor

I guess maybe there's something we didn't handle in WM_NCCALCSIZE handler. It may take some time to look into.

@atraczyk
Copy link
Author

Okay, thanks. Let me know if I can help by providing more information or test results.

@SineStriker SineStriker added the bug Something isn't working label Feb 20, 2024
@SineStriker
Copy link
Contributor

Thanks for using this library, it is a great honor that QWK could be used in such a grand project as JAMI. I'll investigate on a VM later.

@SineStriker
Copy link
Contributor

Since Qt 6.6.1, QTBUG-113736 has been fixed but the fixing patch conflicts with QWindowKit implementation, now I can only set the Qt::FramelessWindowHint to temporarily alleviate this inconsistency, I don't know if it will cause problems elsewhere.

SineStriker added a commit that referenced this issue Feb 24, 2024
SineStriker added a commit that referenced this issue Feb 24, 2024
@SineStriker
Copy link
Contributor

Qt 6.6.2 was released on Feb. 15, this issue has been fixed in the QTBUG-117704 patch, it is highly recommended that you use the newest release, as QWK's current workaround that adapts to 6.6.1 may introduce other issues.

@atraczyk
Copy link
Author

Thanks for using this library, it is a great honor that QWK could be used in such a grand project as JAMI. I'll investigate on a VM later.

Thanks for working on the library. It seems to require a profound knowledge of both the Qt framework and per-platform window management systems. The work is truly appreciated.

@atraczyk
Copy link
Author

Qt 6.6.2 was released on Feb. 15, this issue has been fixed in the QTBUG-117704 patch, it is highly recommended that you use the newest release, as QWK's current workaround that adapts to 6.6.1 may introduce other issues.

Okay, I will bump Qt and QWK and test on Windows ASAP. I'll report back.

@ovari
Copy link

ovari commented Mar 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

4 participants