Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing audio track doesn't change it's name #1349

Closed
IevgenSobko opened this issue May 7, 2024 · 9 comments
Closed

Changing audio track doesn't change it's name #1349

IevgenSobko opened this issue May 7, 2024 · 9 comments

Comments

@IevgenSobko
Copy link

IevgenSobko commented May 7, 2024

Describe the bug
Changing audio track doesn't change it's name in the main UI.
I often use remuxes with multiple audio languages and noticed that when I change for instance audio track 1 in the main UI to some other track the name remains the same as was for first track.

As a workaroud I'm doing audio inclusion from container options modal window and removing every audio from main UI.

@Dendraspis
Copy link
Collaborator

You mean by right-clicking and selecting another track/stream?

@IevgenSobko
Copy link
Author

You mean by right-clicking and selecting another track/stream?

Yep, exactly.

@IevgenSobko
Copy link
Author

Using the following example, it is easy to reproduce
https://drive.proton.me/urls/9J4ANT1B1G#XRQM1vMBQ0aR

@Dendraspis
Copy link
Collaborator

After loading:
image

After selecting other files via right-click:
image

@IevgenSobko
Copy link
Author

IevgenSobko commented May 8, 2024

In this select box, it displays the selected track correctly, but
click Edit and check the name in popup. It should be from an old track, not newly selected.
At least this way it works for me.

@Dendraspis
Copy link
Collaborator

Ahh, now I understand what you mean. 😅

Hmm, but it was always the case, that it is not overwritten, because also custom set track names would be overwritten. 😕

@IevgenSobko
Copy link
Author

IevgenSobko commented May 8, 2024

I believe on selection new track previously it did reassignment to new name parsed from selected track...
But maybe you are correct, and I put here desired instead of what actually was for real.
After further thinking, I'm now recalling cases when sometimes my E-AC-3 tracks had names of TrueHD 🤣(because I changed track in UI)

I'm often selecting different tracks for inclusion and for me it is expected to have name changed once I change track.
At first I would change track and then modify to custom name based on already parsed.
But I found a workaround with Container options audio tab and I actually used to it.

So, I guess, if everyone used to way it is working and never had opened issue on this we can also close this one and I'll use a workaround.

@Dendraspis
Copy link
Collaborator

I keep it open, because I will re-do the whole mechanism at a certain point.

Maybe I can/will implement something, that replaces the name under special circumstances.

@Dendraspis
Copy link
Collaborator

May/should be also solved with the next major release v2.40. We will see as the whole handling will be reset. So I close this now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants