Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically continue the queue after an error #1231

Closed
tormento opened this issue Feb 11, 2024 · 14 comments
Closed

Automatically continue the queue after an error #1231

tormento opened this issue Feb 11, 2024 · 14 comments

Comments

@tormento
Copy link

Is there a way to make StaxRip continue a queue after it has encountered a script or missing file error?

Now, it prompts a error message that needs to be acknowledged but if it happens when the PC is unattended, I lose a lot of hours of encoding.

Is there a setting or can you add it to continue the queue despite the error?

@Dendraspis
Copy link
Collaborator

When you process the jobs list and an error occurs, there will be an error message for ~1min, then StaxRip moves on.
In case that doesn't happen to you, I would need a exact error message you get.

@tormento
Copy link
Author

tormento commented Feb 11, 2024

ok, I will try and report.

@tormento
Copy link
Author

tormento commented Feb 11, 2024

I have deliberately introduced a syntax error in AVS+ script, i.e.

libplacebo_Resample1600,900,filter="lanczos")

instead of

libplacebo_Resample(1600,900,filter="lanczos")

It gives me the error

image

and it stays there indefinitely.

The very same thing happens misleading the dgi file for DGSource:

DGSource("M:\In\- native\Lamu 05 La figlia della casata Mizunokoji_2.dgi")

instead of

DGSource("M:\In\- native\Lamu 05 La figlia della casata Mizunokoji 2.dgi")

It shows

image

and stays there forever too.

If you plan to fix it, please allow an adjustable number of seconds before going on with the next job.

@Dendraspis
Copy link
Collaborator

What was the original source file? Was it an AVS script, the DGI file or a file with another extension?
Can you share the log file?

@tormento
Copy link
Author

tormento commented Feb 11, 2024

Usually I drop the AVS file in the File batch queue.

For wrong syntax:

------------------------- System Environment -------------------------

StaxRip    : v2.35.8
Windows    : Windows 10 Enterprise 24H2 2009 (26052.1000.amd64fre.ge_release.240202-1419)
Language   : Italian (Italy)
CPU        : Intel(R) Core(TM) i7-2600K CPU @ 3.40GHz
RAM        : 16GB
GPU        : NVIDIA GeForce GTX 1660 SUPER
Resolution : 1920 x 1080
DPI        : 96
Code Page  : 1252

----------------------- Media Info Source File -----------------------

M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4.avs

General
Complete name : M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4.avs
File size     : 411 Bytes

------------------------ Error opening source ------------------------

Script error: syntax error
(M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4.avs, line 4, column 83)
(M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4_temp\Shangri-La 18 Sentimenti di un istante, per Setsuna 4_source.avs, line 1)

Import("M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4.avs")

For not found DGI

------------------------- System Environment -------------------------

StaxRip    : v2.35.8
Windows    : Windows 10 Enterprise 24H2 2009 (26052.1000.amd64fre.ge_release.240202-1419)
Language   : Italian (Italy)
CPU        : Intel(R) Core(TM) i7-2600K CPU @ 3.40GHz
RAM        : 16GB
GPU        : NVIDIA GeForce GTX 1660 SUPER
Resolution : 1920 x 1080
DPI        : 96
Code Page  : 1252

----------------------- Media Info Source File -----------------------

M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4.avs

General
Complete name : M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4.avs
File size     : 412 Bytes

------------------------ Error opening source ------------------------

DGSource: Cannot open index file!
(M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4.avs, line 4)
(M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4_temp\Shangri-La 18 Sentimenti di un istante, per Setsuna 4_source.avs, line 1)

Import("M:\In\- native\Shangri-La 18 Sentimenti di un istante, per Setsuna 4.avs")

@Dendraspis
Copy link
Collaborator

Hard to reproduce it as I might need other source files, but can you try this to see if that works or at least changes anything?
StaxRip_v2.35.112.zip (compatible with v2.35)

@tormento
Copy link
Author

tormento commented Feb 12, 2024

.112 is even worse.

With syntax error:

image

That staying there indefinitely. If you close that manually, the next window is

image

and if you close it, StaxRip quits.

Anyway, the steps to reproduce the issue of not jumping to the next job are really easy:

  1. index a video with DGIndexNV
  2. create/edit the AVS to have a syntax error or a dgi not found
  3. feed StaxRip with the avs, dropping to File batch window
  4. start the encoding

@Dendraspis
Copy link
Collaborator

Ok, great, at least I think I know what's causing it.
Will take a while to find a good solution for that.

Thanks, I will try to find a source file for that to reproduce it.

@tormento
Copy link
Author

Any source will fit, enough that it can be indexed by DGIndexNV.

@Dendraspis
Copy link
Collaborator

You could try this one:
StaxRip_v2.35.113.zip (compatible with v2.35)

It's basically the regular build without the error message. Not a great solution, but a workaround for your batch-must-wait problem.

@tormento
Copy link
Author

It skips the error message but the queue doesn't continue, it simply stops.

Perhaps you need to take your time and create a nice error window with timeout.

After the timeout expires, Staxrip continues the queue if not interrupted.

@Dendraspis
Copy link
Collaborator

Damn, forgot another aspect. 🙄
Thanks for trying it out, thought it will continue though.

So it's even harder to solve as this part is used by many functions at different stages. To find a handling for multiple purposes will take a bit of time, so probably not for the next release....

@tormento
Copy link
Author

Every effort is appreciated, thank you!

@Dendraspis
Copy link
Collaborator

Finally found a good way to solve it.
The issue will be fixed at the latest with the next main version v2.40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants