Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The route cannot be disabled when sending assets using the receiver's address with the preferred network. #19818

Closed
Tracked by #19466
VolodLytvynenko opened this issue Apr 26, 2024 · 6 comments
Labels

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Apr 26, 2024

Steps:

  1. Recover the User with available assets on a few networks (for example: Mainnet and Optimism)
  2. Enter into 'send to' page a multichain address using the network preferences of a receiver (example: opt:0x8d....23)
  3. Go to the routes fetching page
  4. Enter available amount on both of your networks (now you see the route is built like this: Sender Mainnet -> Receiver Optimsm)
  5. Tap on Mainnet route into 'to' section to disable it

Actual result:

The route for sender is not disabled

optimism.mp4

Expected result:

The route should be disabled, and a new route with available assets should be fetched (similar to how it works for desktop).

trimmed.mp4

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17
@OmarBasem
Copy link
Member

@briansztamfater is this issue fixed in your PR #19768 ?

@briansztamfater
Copy link
Member

I think it is, I am currently AFK so I can't check, but I would suggest to wait until the refactor is merged to work on routes related issues

@VolodLytvynenko
Copy link
Contributor Author

@OmarBasem Today I'll check in on #19768 and let you know. If it's fixed, I'll close the current issue, or I'll ping you if it's not fixed

@VolodLytvynenko
Copy link
Contributor Author

VolodLytvynenko commented May 2, 2024

it's work) correctly here #19768
cc: @briansztamfater @OmarBasem

@briansztamfater
Copy link
Member

Sorry I didn't understand if this was fixed on #19768, @VolodLytvynenko is this still relevant?

@VolodLytvynenko
Copy link
Contributor Author

Sorry I didn't understand if this was fixed on #19768, @VolodLytvynenko is this still relevant?

Hi @briansztamfater I forgot to close this after merging of #19768
Now it works correctly in develop and this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants