Changing theme not working properly

[Parveshdhull]

Check video at 00:20 sec

output-2024-04-25_15.06.59.mp4

[flexsurfer]

i'm unable to replicate this

[Parveshdhull]

weird, on my emulator several screens broke using above steps but on android device only activity center icon broken in wallet screen

[flexsurfer]

super weird

[Parveshdhull]

if its only happening in emulator we can close the issue. Please can you confirm if activity center icon is correct for you after theme changes?

[flexsurfer]

but still strange why it happens on emulator

[Parveshdhull]

probably some timing issue, it happens randomly. So maybe timing problem with hot-reload and theme change

[flexsurfer]

btw why do we need hot-reload?

[Parveshdhull]

do we even need hot-reloatd anymore

[Parveshdhull]

btw why do we need hot-reload?

I don't remember why we needed, have to check

[Parveshdhull]

btw why do we need hot-reload?

found it, #14811 (comment)

[Parveshdhull]

But from implementation it seems, initially we added hot-reload for all builds not only debug. Not sure when and why we changed it to only debug build. Still, we probably don't need it 🤔

[Parveshdhull]

Closing issue for now, if we ever want to fix this issue, probably removing these lines should be solution

status-mobile/src/status_im/contexts/profile/settings/effects.cljs

Lines 34 to 35 in d8e3934

	(when js/goog.DEBUG
	(hot-reload/reload))))))

Currently don't want to remove them without knowing what will be side-effects