Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate max value when network is disabled #19791

Open
Tracked by #18673
VolodLytvynenko opened this issue Apr 24, 2024 · 5 comments
Open
Tracked by #18673

Recalculate max value when network is disabled #19791

VolodLytvynenko opened this issue Apr 24, 2024 · 5 comments
Assignees
Labels
E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Send Page MVP all issues for the send page of the wallet feature feature requests

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Apr 24, 2024

As a user, when I disable a route in the 'From' column on the sending assets page (as shown in this flow), I expect the max value to be recalculated based on the rest of the enabled networks.
Additionally, the disabled network label should not be shown in the max value. For example, if I disable eth route, then in the max value label, I should only see arb1 and opt.

Discussed with a design team https://discord.com/channels/624634427930312714/852533718790570015/1232324734511878329

@VolodLytvynenko VolodLytvynenko added feature feature requests E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Networks and Routes E:Mobile Wallet Send Page MVP all issues for the send page of the wallet and removed E:Mobile Wallet Networks and Routes labels Apr 24, 2024
@OmarBasem
Copy link
Member

@briansztamfater is that issue also fixed there #19768 ?

@briansztamfater
Copy link
Member

No, we should implement this

@briansztamfater
Copy link
Member

As a user, when I disable a route in the 'To' column

@VolodLytvynenko shouldn't it be in the 'From' column?

@VolodLytvynenko
Copy link
Contributor Author

VolodLytvynenko commented May 6, 2024

As a user, when I disable a route in the 'To' column

@VolodLytvynenko shouldn't it be in the 'From' column?

@briansztamfater Correct. My fault. Updated in description

@BalogunofAfrica
Copy link
Contributor

There is a case where if a user disables routes that have a balance leaving only the one with 0 balances, we display an error on the input and do not search further for routes which means we do not show the routes again and the user doesn't get to select the routes where they have some money.

How should this be handled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Send Page MVP all issues for the send page of the wallet feature feature requests
Projects
Status: No status
Development

No branches or pull requests

4 participants