Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chat] Unread badge even for unreachable channels #14421

Closed
caybro opened this issue Apr 12, 2024 · 2 comments · Fixed by status-im/status-go#5062 or #14793
Closed

[Chat] Unread badge even for unreachable channels #14421

caybro opened this issue Apr 12, 2024 · 2 comments · Fixed by status-im/status-go#5062 or #14793

Comments

@caybro
Copy link
Member

caybro commented Apr 12, 2024

Bug Report

No other channel or category is highlighted nor has any unread messages, so I'm assuming there's a hidden (unreachable to me due to permissions) channel here in the Mobile category that has some unread messages.

image

Expected behavior

No highlighted category, no unread msg badge in the primary nav

Actual behavior

Highlighted category, unread msg primary badge

Additional Information

  • Status desktop version: master
  • Operating System: linux
@caybro caybro added this to the 2.29.0 Beta milestone Apr 12, 2024
@jrainville jrainville self-assigned this Apr 12, 2024
@caybro
Copy link
Member Author

caybro commented Apr 15, 2024

Similar thing for an unjoined community:
image

@jrainville
Copy link
Member

I can reproduce the issue. It seems to happen only on restart. When you first receive the messages, the count doesn't update, but on restart it does.
Even my branch with the refactor has the issue.

I'm investigating at which level it fails.

jrainville added a commit to status-im/status-go that referenced this issue Apr 16, 2024
…s you can't view

Fixes status-im/status-desktop#14421

The problem is that you can receive messages to  a channel, then later, before marking them as read, a permisison is added to them, so you no longer have access.
Then, you can't even mark it as read if it's hidden.
Here, I fix it by setting the unread count on Init at 0 if the user doesn't have view access to it.
jrainville added a commit to status-im/status-go that referenced this issue Apr 16, 2024
…s you can't view

Fixes status-im/status-desktop#14421

The problem is that you can receive messages to  a channel, then later, before marking them as read, a permisison is added to them, so you no longer have access.
Then, you can't even mark it as read if it's hidden.
Here, I fix it by setting the unread count on Init at 0 if the user doesn't have view access to it.
jrainville added a commit to status-im/status-go that referenced this issue Apr 17, 2024
…s you can't view

Fixes status-im/status-desktop#14421

The problem is that you can receive messages to  a channel, then later, before marking them as read, a permisison is added to them, so you no longer have access.
Then, you can't even mark it as read if it's hidden.
Here, I fix it by setting the unread count on Init at 0 if the user doesn't have view access to it.
jrainville added a commit to status-im/status-go that referenced this issue Apr 19, 2024
…ls you can't view

Fixes status-im/status-desktop#14421

The problem is that you can receive messages to  a channel, then later, before marking them as read, a permission is added to them, so you no longer have access.
Then, you can't even mark it as read if it's hidden.
Here, I fix it by setting the unread count on Init at 0 if the user doesn't have view access to it. And I make sure we update the counts when we are removed from a channel
jrainville added a commit to status-im/status-go that referenced this issue Apr 19, 2024
…ls you can't view

Fixes status-im/status-desktop#14421

The problem is that you can receive messages to  a channel, then later, before marking them as read, a permission is added to them, so you no longer have access.
Then, you can't even mark it as read if it's hidden.
Here, I fix it by setting the unread count on Init at 0 if the user doesn't have view access to it. And I make sure we update the counts when we are removed from a channel
jrainville added a commit to status-im/status-go that referenced this issue Apr 19, 2024
…ls you can't view

Fixes status-im/status-desktop#14421

The problem is that you can receive messages to  a channel, then later, before marking them as read, a permission is added to them, so you no longer have access.
Then, you can't even mark it as read if it's hidden.
Here, I fix it by setting the unread count on Init at 0 if the user doesn't have view access to it. And I make sure we update the counts when we are removed from a channel
jrainville added a commit to status-im/status-go that referenced this issue May 15, 2024
…ls you can't view

Fixes status-im/status-desktop#14421

The problem is that you can receive messages to  a channel, then later, before marking them as read, a permission is added to them, so you no longer have access.
Then, you can't even mark it as read if it's hidden.
Here, I fix it by setting the unread count on Init at 0 if the user doesn't have view access to it. And I make sure we update the counts when we are removed from a channel
jrainville added a commit to status-im/status-go that referenced this issue May 15, 2024
…ls you can't view (#5062)

Fixes status-im/status-desktop#14421

The problem is that you can receive messages to  a channel, then later, before marking them as read, a permission is added to them, so you no longer have access.
Then, you can't even mark it as read if it's hidden.
Here, I fix it by setting the unread count on Init at 0 if the user doesn't have view access to it. And I make sure we update the counts when we are removed from a channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment