Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve watchCommunitiesToUnmute #5014

Open
1 task
osmaczko opened this issue Apr 4, 2024 · 1 comment
Open
1 task

Improve watchCommunitiesToUnmute #5014

osmaczko opened this issue Apr 4, 2024 · 1 comment

Comments

@osmaczko
Copy link
Contributor

osmaczko commented Apr 4, 2024

Problem

watchCommunitiesToUnmute reads all community info from the database in the loop. That's pretty expensive, see: #5012 (comment). Even though the problem was mitigated by increasing the interval, the procedure should be improved. Instead of unmarshaling all community data, only muted and mutedTill columns should be read from the db.

Acceptance Criteria

  • CheckCommunitiesToUnmute quires only subset (muted&mutedTill) of community data
@jrainville
Copy link
Member

One additional improvement that might be possible is to do the procedure only when there are muted communities. Right now, if there are no muted communities or if they are muted "indefinitely", we still run the procedure.

But that is a bit more error prone, since we need to start/restart the procedure once one community is muted with a timer, so it might not be worth it.

@jrainville jrainville removed this from the 2.30.0 Beta milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants