Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Community tokens] Move transaction listening to status-go - improvement #4351

Closed
endulab opened this issue Nov 21, 2023 · 1 comment · Fixed by #4953 or status-im/status-desktop#14413
Closed

[Community tokens] Move transaction listening to status-go - improvement #4351

endulab opened this issue Nov 21, 2023 · 1 comment · Fixed by #4953 or status-im/status-desktop#14413
Assignees
@endulab
Labels
backend-team E:Communities MVP feature refactor
Milestone
2.29.0 Beta

Comments

@endulab
Copy link
Contributor

endulab commented Nov 21, 2023 •
edited

The purpose of this task is to move transaction listening logic from client code to status-go.

Background

All operations in community tokens service consist of 2 steps:

  1. contract interaction, and then
  2. logic operation (eg. adding a token to a database, promoting to control node).

The complexity of the flow is high because it is divided into status-go and client code.
There are many calls to status-go from a client
This is not good also for a mobile team if they want to add a token minting functionality, because they will have to implement a lot of logic.

The reason of this situation is the legacy transaction system which required client interaction. Now, it has changed, and we can listen to transactions on status-go side.

Solution

A new schema will look like this:

  • Client asks status-go to do operation
  • Status-go does blockchain operation and listens to transaction
  • When transaction is finished status-go does some logic, eg. database update. It should also add AC notification if needed
  • The signal is send to client only to show toast messages or update model.
@endulab endulab self-assigned this Nov 21, 2023
@endulab endulab changed the title Move transaction listening to status-go [Community tokens] Move transaction listening to status-go - improvement Nov 21, 2023
@jrainville jrainville transferred this issue from status-im/status-desktop Nov 21, 2023
@endulab
Copy link
Contributor Author

endulab commented Nov 27, 2023

FYI @cammellos
If you want to introduce minting in mobile, maybe you should do this in a new way.

@endulab endulab self-assigned this Mar 13, 2024
@jrainville jrainville added this to the 2.28.0 Beta milestone Mar 13, 2024
@jrainville jrainville modified the milestones: 2.28.0 Beta, 2.29.0 Beta Mar 26, 2024
@jrainville jrainville mentioned this issue Mar 27, 2024
Closed
endulab added a commit that referenced this issue Apr 11, 2024
@endulab
feat: Move community tokens transaction listening to status-go
3f9325e 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
@endulab endulab mentioned this issue Apr 11, 2024
Merged
endulab added a commit that referenced this issue Apr 11, 2024
@endulab
feat: Move community tokens transaction listening to status-go
6372de1 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
@stefandunca stefandunca mentioned this issue Apr 12, 2024
Closed
@endulab endulab linked a pull request Apr 12, 2024 that will close this issue
Move transaction listening to status-go #4953
Merged
@endulab endulab mentioned this issue Apr 12, 2024
Merged
@endulab endulab linked a pull request Apr 12, 2024 that will close this issue
4351 community token refactoring status-im/status-desktop#14413
Merged
endulab added a commit that referenced this issue Apr 15, 2024
@endulab
feat: Move community tokens transaction listening to status-go
fe9b825 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
endulab added a commit that referenced this issue Apr 18, 2024
@endulab
feat: Move community tokens transaction listening to status-go
615d2cc 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
endulab added a commit that referenced this issue Apr 18, 2024
@endulab
feat_: Move community tokens transaction listening to status-go
1a52367 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
endulab added a commit that referenced this issue Apr 18, 2024
@endulab
feat_: Move community tokens transaction listening to status-go
5d139ac 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
endulab added a commit that referenced this issue Apr 18, 2024
@endulab
feat_: Move community tokens transaction listening to status-go
2e94b07 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
endulab added a commit that referenced this issue Apr 25, 2024
@endulab
feat_: Move community tokens transaction listening to status-go
565f8d1 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
endulab added a commit that referenced this issue May 6, 2024
@endulab
feat_: Move community tokens transaction listening to status-go
98b7a47 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
endulab added a commit that referenced this issue May 13, 2024
@endulab
feat_: Move community tokens transaction listening to status-go
5ad3a3d 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
endulab added a commit that referenced this issue May 16, 2024
@endulab
feat_: Move community tokens transaction listening to status-go
5744502 
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.

Issue #4351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@endulab endulab

Labels
backend-team E:Communities MVP feature refactor
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.29.0 Beta
3 participants
@iurimatias @jrainville @endulab