Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test - TestCreateAccountAndLogin #4527

Closed
rasom opened this issue Jan 4, 2024 · 4 comments · Fixed by #5056
Closed

Flaky test - TestCreateAccountAndLogin #4527

rasom opened this issue Jan 4, 2024 · 4 comments · Fixed by #5056
Assignees
@qfrank
Labels
E:Flaky Test

Comments

@rasom
Copy link
Member

rasom commented Jan 4, 2024 

INFO [01-04|14:21:27.743|github.com/waku-org/go-waku/waku/v2/peermanager/peer_manager.go:388]               adding peer to peerstore                 peer=16Uiu2HAm1fVVprL9EaDpDw4frNX3CPfZu5cBqhtk9Ncm6WCvprpv
    create_account_and_login_test.go:49: TestCreateAccountAndLogin: create account user1 and login successfully
    create_account_and_login_test.go:53: TestCreateAccountAndLogin: logouting
panic: test timed out after 30m0s
@osmaczko osmaczko mentioned this issue Jan 18, 2024
Closed
@qfrank qfrank self-assigned this Apr 10, 2024
@qfrank
Copy link
Contributor

qfrank commented Apr 10, 2024 •
edited

reproduced in this PR test TestMessageSent

    messenger_raw_message_resend_test.go:110: Boot Node Stop completed successfully.
    messenger_raw_message_resend_test.go:110: Bob Logout completed successfully.
    messenger_raw_message_resend_test.go:117: Timeout occurred, the following operations did not complete in time:
    messenger_raw_message_resend_test.go:120: Alice Logout is still pending.
    --- FAIL: TestMessengerRawMessageResendTestSuite/TestMessageSent (34.73s)

@qfrank
Copy link
Contributor

qfrank commented Apr 10, 2024

reproduce command:

go test -tags gowaku_skip_migrations -test.v -run TestMessengerRawMessageResendTestSuite -test.count=100 -testify.m ^TestMessageSent$ github.com/status-im/status-go/api

@qfrank
Copy link
Contributor

qfrank commented Apr 10, 2024 •
edited

suspicious goroutines:

1 @ 0x1024bdcb4 0x1024cfe6c 0x1024cfe49 0x1024ee17c 0x1024ff3e8 0x1030206d4 0x103020d98 0x103020660 0x10304a734 0x1033df8bc 0x1033df094 0x1024f2d24
#	0x1024ee17b	sync.runtime_Semacquire+0x2b								/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/runtime/sema.go:62
#	0x1024ff3e7	sync.(*WaitGroup).Wait+0x77								/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/sync/waitgroup.go:116
#	0x1030206d3	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).Stop.func1+0x43	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:43
#	0x103020d97	github.com/waku-org/go-waku/waku/v2/service.(*CommonService).Stop+0x77			/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_service.go:55
#	0x10302065f	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).Stop+0x3f		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:41
#	0x10304a733	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).Stop+0x63			/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:246
#	0x1033df8bb	github.com/status-im/status-go/wakuv2.(*Waku).restartDiscV5+0xfb			/Users/frank/development/go/src/github.com/status-im/status-go/wakuv2/waku.go:1677
#	0x1033df093	github.com/status-im/status-go/wakuv2.(*Waku).seedBootnodesForDiscV5+0x453		/Users/frank/development/go/src/github.com/status-im/status-go/wakuv2/waku.go:1622




1 @ 0x1024bdcb4 0x1024cfe6c 0x1024cfe49 0x1024ee268 0x1024fd528 0x1024feda4 0x1024fed49 0x103020d50 0x103020660 0x10304a734 0x1033be0c8 0x1033dc6c0 0x10345b798 0x10345af24 0x103ec2230 0x103ec1ff4 0x103ee1d38 0x103ef16f4 0x1024f2d24
#	0x1024ee267	sync.runtime_SemacquireMutex+0x27								/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/runtime/sema.go:77
#	0x1024fd527	sync.(*Mutex).lockSlow+0x177									/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/sync/mutex.go:171
#	0x1024feda3	sync.(*Mutex).Lock+0x73										/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/sync/mutex.go:90
#	0x1024fed48	sync.(*RWMutex).Lock+0x18									/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/sync/rwmutex.go:147
#	0x103020d4f	github.com/waku-org/go-waku/waku/v2/service.(*CommonService).Stop+0x2f				/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_service.go:49
#	0x10302065f	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).Stop+0x3f			/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:41
#	0x10304a733	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).Stop+0x63				/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:246
#	0x1033be0c7	github.com/waku-org/go-waku/waku/v2/node.(*WakuNode).Stop+0x277					/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/node/wakunode2.go:535
#	0x1033dc6bf	github.com/status-im/status-go/wakuv2.(*Waku).Stop+0x4f						/Users/frank/development/go/src/github.com/status-im/status-go/wakuv2/waku.go:1295
#	0x10345b797	github.com/ethereum/go-ethereum/node.(*Node).stopServices+0xb7					/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/ethereum/go-ethereum/node/node.go:298
#	0x10345af23	github.com/ethereum/go-ethereum/node.(*Node).Close+0x1e3					/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/ethereum/go-ethereum/node/node.go:218
#	0x103ec222f	github.com/status-im/status-go/node.(*StatusNode).stop+0x13f					/Users/frank/development/go/src/github.com/status-im/status-go/node/get_status_node.go:460
#	0x103ec1ff3	github.com/status-im/status-go/node.(*StatusNode).Stop+0x83					/Users/frank/development/go/src/github.com/status-im/status-go/node/get_status_node.go:446
#	0x103ee1d37	github.com/status-im/status-go/api.(*GethStatusBackend).Logout+0x187				/Users/frank/development/go/src/github.com/status-im/status-go/api/geth_backend.go:2222
#	0x103ef16f3	github.com/status-im/status-go/api.(*MessengerRawMessageResendTest).TearDownTest.func1+0x33	/Users/frank/development/go/src/github.com/status-im/status-go/api/messenger_raw_message_resend_test.go:91



1 @ 0x1024bdcb4 0x1024cfe6c 0x1024cfe49 0x1024ee2c8 0x1030209dc 0x103020989 0x103020768 0x10304bfbc 0x10304b4b0 0x10304bea0 0x10304c3a4 0x10304a5ac 0x1024f2d24
#	0x1024ee2c7	sync.runtime_SemacquireRWMutexR+0x27							/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/runtime/sema.go:82
#	0x1030209db	sync.(*RWMutex).RLock+0x6b								/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/sync/rwmutex.go:71
#	0x103020988	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).RLock+0x18	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:66
#	0x103020767	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).PushToChan+0x57	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:52
#	0x10304bfbb	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).peerLoop.func1+0xab		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:444
#	0x10304b4af	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).Iterate+0x39f			/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:337
#	0x10304be9f	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).peerLoop+0x13f		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:437
#	0x10304c3a3	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).runDiscoveryV5Loop+0x133	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:474
#	0x10304a5ab	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).start.func1+0x6b		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:221

1 @ 0x1024bdcb4 0x1024cfe6c 0x1024cfe49 0x1024ee2c8 0x1030209dc 0x103020989 0x103020768 0x10304bfbc 0x10304b4b0 0x10304bea0 0x10304c3a4 0x10304a5ac 0x1024f2d24
#	0x1024ee2c7	sync.runtime_SemacquireRWMutexR+0x27							/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/runtime/sema.go:82
#	0x1030209db	sync.(*RWMutex).RLock+0x6b								/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/sync/rwmutex.go:71
#	0x103020988	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).RLock+0x18	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:66
#	0x103020767	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).PushToChan+0x57	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:52
#	0x10304bfbb	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).peerLoop.func1+0xab		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:444
#	0x10304b4af	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).Iterate+0x39f			/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:337
#	0x10304be9f	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).peerLoop+0x13f		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:437
#	0x10304c3a3	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).runDiscoveryV5Loop+0x133	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:474
#	0x10304a5ab	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).start.func1+0x6b		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:221

@qfrank
Copy link
Contributor

qfrank commented Apr 10, 2024

cause:

1 @ 0x1024bdcb4 0x1024cfe6c 0x1024cfe49 0x1024ee17c 0x1024ff3e8 0x1030206d4 0x103020d98 0x103020660 0x10304a734 0x1033df8bc 0x1033df094 0x1024f2d24
#	0x1024ee17b	sync.runtime_Semacquire+0x2b								/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/runtime/sema.go:62
#	0x1024ff3e7	sync.(*WaitGroup).Wait+0x77								/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/sync/waitgroup.go:116
#	0x1030206d3	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).Stop.func1+0x43	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:43
#	0x103020d97	github.com/waku-org/go-waku/waku/v2/service.(*CommonService).Stop+0x77			/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_service.go:55
#	0x10302065f	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).Stop+0x3f		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:41
#	0x10304a733	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).Stop+0x63			/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:246
#	0x1033df8bb	github.com/status-im/status-go/wakuv2.(*Waku).restartDiscV5+0xfb			/Users/frank/development/go/src/github.com/status-im/status-go/wakuv2/waku.go:1677
#	0x1033df093	github.com/status-im/status-go/wakuv2.(*Waku).seedBootnodesForDiscV5+0x453		/Users/frank/development/go/src/github.com/status-im/status-go/wakuv2/waku.go:1622


1 @ 0x1024bdcb4 0x1024cfe6c 0x1024cfe49 0x1024ee2c8 0x1030209dc 0x103020989 0x103020768 0x10304bfbc 0x10304b4b0 0x10304bea0 0x10304c3a4 0x10304a5ac 0x1024f2d24
#	0x1024ee2c7	sync.runtime_SemacquireRWMutexR+0x27							/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/runtime/sema.go:82
#	0x1030209db	sync.(*RWMutex).RLock+0x6b								/opt/homebrew/Cellar/go@1.20/1.20.11/libexec/src/sync/rwmutex.go:71
#	0x103020988	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).RLock+0x18	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:66
#	0x103020767	github.com/waku-org/go-waku/waku/v2/service.(*CommonDiscoveryService).PushToChan+0x57	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/service/common_discovery_service.go:52
#	0x10304bfbb	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).peerLoop.func1+0xab		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:444
#	0x10304b4af	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).Iterate+0x39f			/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:337
#	0x10304be9f	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).peerLoop+0x13f		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:437
#	0x10304c3a3	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).runDiscoveryV5Loop+0x133	/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:474
#	0x10304a5ab	github.com/waku-org/go-waku/waku/v2/discv5.(*DiscoveryV5).start.func1+0x6b		/Users/frank/development/go/src/github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go:221

This was referenced Apr 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qfrank qfrank

Labels
E:Flaky Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix_: logout deadlock status-im/status-go
2 participants
@rasom @qfrank