Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the number of community members #14532

Closed
jrainville opened this issue Apr 26, 2024 · 1 comment
Closed

Limit the number of community members #14532

jrainville opened this issue Apr 26, 2024 · 1 comment
Assignees
@jrainville
Labels
backend-team chore
Milestone
2.28.1 Beta

Comments

@jrainville
Copy link
Member

jrainville commented Apr 26, 2024 •
edited

Description

To make sure the app stays performant, we will set a hard cap on the number of community members.

That cap needs to be editable relatively easily so that if everything goes well, we can increase it for example.

There are two possible options, from hardest to easiest:

  1. Set a cap on status-go and when that cap is reached, automatically switch from Open to On Request
  2. Set a hard cap in status-go that throws away new requests when the limit is reached.
    Do not reject it, just ignore it, that way it stays pending for the user and it will expire and they can send it again later (if the limit is increased)
@jrainville jrainville added this to the 2.28.1 Beta milestone Apr 26, 2024
@jrainville jrainville self-assigned this Apr 27, 2024
jrainville added a commit to status-im/status-go that referenced this issue Apr 30, 2024
@jrainville
feat(community): limit nb of requests to join and members
98a384c 
Needed for status-im/status-desktop#14532
@jrainville jrainville mentioned this issue Apr 30, 2024
Merged
jrainville added a commit to status-im/status-go that referenced this issue May 1, 2024
@jrainville
feat_: Limit number of members in a community and number of pending r…
62fa322 
…equests (#5105)

* feat(community): limit nb of requests to join and members

Needed for status-im/status-desktop#14532

* chore: simplify TestRequestAccessAgain

* chore: add a test for the member limit
jrainville added a commit to status-im/status-go that referenced this issue May 1, 2024
@jrainville
feat_: limit number of members in a community and number of pending r…
367ca99 
…equests

* feat(community): limit nb of requests to join and members

Needed for status-im/status-desktop#14532

* chore: simplify TestRequestAccessAgain

* chore: add a test for the member limit
jrainville added a commit to status-im/status-go that referenced this issue May 1, 2024
@jrainville
feat_: limit number of members in a community and number of pending r…
852a5be 
…equests (#5107)

* feat(community): limit nb of requests to join and members

Needed for status-im/status-desktop#14532

* chore: simplify TestRequestAccessAgain

* chore: add a test for the member limit
jrainville added a commit that referenced this issue May 1, 2024
@jrainville
chore(status-go): bump status-go to get RAM fix + limit nb of members
0838cd1 
Fixes #14532
@jrainville jrainville mentioned this issue May 1, 2024
Merged
jrainville added a commit that referenced this issue May 1, 2024
@jrainville
chore(status-go): bump status-go to get RAM fix + limit nb of members
e75d769 
Fixes #14532
@jrainville
Copy link
Member Author

Fixed in #14566 and status-im/status-go#5105
Cherry-picked here: status-im/status-go#5107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
backend-team chore
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.28.1 Beta
Development

No branches or pull requests
1 participant
@jrainville