100% of the CPU is used when there is no network

[friofry]

Bug Report

Description

When running Status Desktop without an Internet connection, CPU usage is very high.
Doesn't reproduce when network is enabled.

Steps to reproduce

1. Turn off the network on the computer
2. Launch the application

Expected behavior

CPU usage should be as low as possible (around 0-3%).

Actual behavior

High CPU usage on application startup

Additional Information

CPU usage is low when network is on

network_on.mp4

CPU usage is high when there is no network

no_network.mp4

• Status desktop version: master on e8a78e21

• Operating System: Macos

[jrainville]

@friofry it should be easy to identify the source if you use something like hotspot. However, this one is for Linux, so you'd need to find a Mac version (I assume it exists somewhere).
If you can't find something that works for you, I can reassign to someone that's on Linux

[caybro]

@friofry it should be easy to identify the source if you use something like hotspot. However, this one is for Linux, so you'd need to find a Mac version (I assume it exists somewhere).
If you can't find something that works for you, I can reassign to someone that's on Linux

Hotspot is Linux exclusive

[friofry]

The issue is related to the manager.go StartTorrentClient() method.

(I'm using the MacOS CPU profiler from Instruments and building the application with INCLUDE_DEBUG_SYMBOLS=true).

If I comment out this call, the CPU usage is normal. I continue to investigate this issue.

[jrainville]

Good find. If we can use some kind of function that can tell us if we have connection, then we can skip this function until connection is re-established. @richard-ramos might have an idea if we have such a function

[richard-ramos]

The function SubscribeToConnStatusChanges in status-go could be used to determine if you're connected or not.
Here's an example on how it can be used: https://github.com/status-im/status-go/blob/8a0b7ddbb57bcf7e6a244bc15c3e0828c1f85f99/protocol/messenger_testing_utils.go#L194-L214

This function is available in Transport so I think it should be possible to call it from protocol/communities/messenger_communities.go and protocol/communities/manager.go (that's where I saw calls to StartTorrentClient and StopTorrentClient

[friofry]

The function SubscribeToConnStatusChanges in status-go could be used to determine if you're connected or not. Here's an example on how it can be used: https://github.com/status-im/status-go/blob/8a0b7ddbb57bcf7e6a244bc15c3e0828c1f85f99/protocol/messenger_testing_utils.go#L194-L214

This function is available in Transport so I think it should be possible to call it from protocol/communities/messenger_communities.go and protocol/communities/manager.go (that's where I saw calls to StartTorrentClient and StopTorrentClient

Thanks for the hint! I'll try this