Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WalletConnect] initial code organization #14395

Closed
saledjenic opened this issue Apr 10, 2024 · 2 comments
Closed

[WalletConnect] initial code organization #14395

saledjenic opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
E:Desktop WalletConnect Implement Desktop WalletConnect support feature wallet-team
Milestone

Comments

@saledjenic
Copy link
Contributor

Under this issue we should identify:

  • what should go where and for the wallet connect feature, making a structure
  • keep the POC wallet connect code live for testing and referencing to it, but make it easy to identify for removal once wallet connect is fully implemented
@saledjenic saledjenic added wallet-team feature E:Desktop WalletConnect Implement Desktop WalletConnect support labels Apr 10, 2024
@saledjenic saledjenic self-assigned this Apr 10, 2024
saledjenic added a commit that referenced this issue Apr 12, 2024
@clauxx
Copy link
Member

clauxx commented Apr 30, 2024

@saledjenic Hey Sale! I guess all the issues under the E:Desktop WalletConnect label were added before the descoping sessions we had. Would it be fine to close them so we can create user stories based on the newly descoped designs?

cc: @stefandunca

@saledjenic
Copy link
Contributor Author

@saledjenic Hey Sale! I guess all the issues under the E:Desktop WalletConnect label were added before the descoping sessions we had. Would it be fine to close them so we can create user stories based on the newly descoped designs?

cc: @stefandunca

@clauxx yes, they were added before descoping.
I wouldn't close the epic, cause sooner or later we will need to implement them all, maybe better to add another epic, like [EPIC] WalletConnect - descoped and add issues there and just make reference from full epic to descoped epic.

@saledjenic saledjenic added this to the 2.29.0 Beta milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Desktop WalletConnect Implement Desktop WalletConnect support feature wallet-team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants