Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 404 errors in getAggregatedAttestation response #6184

Closed
nflaig opened this issue Apr 8, 2024 · 1 comment
Closed

Handle 404 errors in getAggregatedAttestation response #6184

nflaig opened this issue Apr 8, 2024 · 1 comment

Comments

@nflaig
Copy link

nflaig commented Apr 8, 2024

As per spec the getAggregatedAttestation could return a 404 status code if no aggregated attestation is available

apis/validator/aggregate_attestation.yaml#L11-L12

A 404 error must be returned if no attestation is available for the requested attestation_data_root.

But it looks like Nimbus does not specifically handle this case right now which would lead to an error that looks critical but are somewhat expected if Nimbus VC is connected to multiple BNs (see ChainSafe/lodestar#6634 (comment))

handleUnexpectedCode()
ApiResponse[GetAggregatedAttestationResponse].err(
ResponseUnexpectedError)

We have been getting user reports about this ChainSafe/lodestar#6631 which we already addressed on the Lodestar bn (ChainSafe/lodestar#6648) but based on how our attestation cache works Lodestar bn might not be able to serve this request.

Maybe Nimbus VC could also consider to log this differently to avoid user concerns, as based on how Nimbus handles this, if one of the connected BNs is not able to serve the request, it's not critical.

@tersec
Copy link
Contributor

tersec commented May 1, 2024

#6254

@tersec tersec closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants