Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

per-chunk validation of libp2p req/resp chunk #5557

Open
etan-status opened this issue Nov 3, 2023 · 0 comments
Open

per-chunk validation of libp2p req/resp chunk #5557

etan-status opened this issue Nov 3, 2023 · 0 comments

Comments

@etan-status
Copy link
Contributor

Before consuming the next response chunk, the response reader SHOULD verify the blob sidecar is well-formatted, has valid inclusion proof, and is correct w.r.t. the expected KZG commitments through verify_blob_kzg_proof.

When fetching BlobSidecar via libp2p req/resp, v1.4.0-beta.4 spec now suggests incrementally validating chunks before processing next one.

In Nimbus we currently don't have infrastructure to process chunks while followup parts of the response are still pending download.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@etan-status