Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent types for address field in logs #5503

Open
jakubgs opened this issue Oct 12, 2023 · 1 comment
Open

Inconsistent types for address field in logs #5503

jakubgs opened this issue Oct 12, 2023 · 1 comment

Comments

@jakubgs
Copy link
Member

jakubgs commented Oct 12, 2023

Currently our Logstash is generating a LOT of warnings like this:

object mapping for [json.address] tried to parse field [address] as object, but found a concrete value

This happens because the address field is sometimes a string:

{"lvl":"DBG","ts":"2023-10-12 17:37:17.265+00:00","msg":"Timed out or unrequested whoareyou packet","topics":"eth p2p discv5","address":"75.119.130.1:30303"}

And sometimes an object:

{"lvl":"DBG","ts":"2023-10-12 17:44:13.179+00:00","msg":"Sending message to RPC server","topics":"JSONRPC-HTTP-CLIENT","address":{"oResultPrivate":true,"vResultPrivate":{"id":"localhost:8552","scheme":"NonSecure","hostname":"localhost","port":8552,"path":"","query":"","anchor":"","username":"","password":"","addresses":[{"family":"IPv4","address_v4":[127,0,0,1],"port":8552}]}},"msg_len":345,"name":"engine_forkchoiceUpdatedV2"}

Could we please make this consistent?

@jakubgs
Copy link
Member Author

jakubgs commented Oct 12, 2023

Silenced as well:

Will undo it once this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant