Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent types for blck field in logs #5502

Open
jakubgs opened this issue Oct 12, 2023 · 1 comment
Open

Inconsistent types for blck field in logs #5502

jakubgs opened this issue Oct 12, 2023 · 1 comment

Comments

@jakubgs
Copy link
Member

jakubgs commented Oct 12, 2023

Currently our Logstash is generating a LOT of warnings like this:

object mapping for [json.blck] tried to parse field [blck] as object, but found a concrete value

This happens because the blck field is sometimes a string:

{"lvl":"DBG","ts":"2023-10-12 17:01:25.591+00:00","msg":"Block processed","topics":"gossip_blocks","head":"a095cc13:102307","blck":"a095cc13:102307","validationDur":{"value":6984913},"queueDur":{"value":7478020},"newPayloadDur":{"value":11735973},"addHeadBlockDur":{"value":457713354},"updateHeadDur":{"value":77371194}}

And sometimes an object:

{"lvl":"DBG","ts":"2023-10-12 17:01:13.096+00:00","msg":"Block resolved","topics":"gossip_blocks","blockRoot":"2475ee73","blck":{"slot":102306,"proposer_index":1121517,"parent_root":"942b54b6","state_root":"f2826448","eth1data":{"deposit_root":"d74ead9c148de2282598d91ab8236efbb5e05b24eabdf8797f68c8982f715748","deposit_count":1719,"block_hash":"7c6e1a334fdee6cd13df9a86aec02867b2d7c5f9bdbf3d760fd991d3e73fa07a"},"graffiti":"\"prysm-k8s-holesky\"","proposer_slashings_len":0,"attester_slashings_len":0,"attestations_len":128,"deposits_len":0,"voluntary_exits_len":0,"sync_committee_participants":455,"block_number":92604,"fee_recipient":"0x0c10000000756bd1d14f9c837f022929a97bda45","bls_to_execution_changes_len":16,"blob_kzg_commitments_len":0},"executionValid":true,"heads":1,"stateDataDur":{"value":2373209},"sigVerifyDur":{"value":242454629},"stateVerifyDur":{"value":84085379},"putBlockDur":{"value":868486},"epochRefDur":{"value":8164}}

Could we please make this consistent?

@jakubgs
Copy link
Member Author

jakubgs commented Oct 12, 2023

I've filtered out these logs:

Will undo that once this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant