Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid use of nimbus db/core_db in Fluffy #2146

Closed
kdeme opened this issue Apr 23, 2024 · 2 comments
Closed

Avoid use of nimbus db/core_db in Fluffy #2146

kdeme opened this issue Apr 23, 2024 · 2 comments
Assignees
@web3-developer
Labels
Fluffy

Comments

@kdeme
Copy link
Contributor

kdeme commented Apr 23, 2024

The Fluffy code has evolved so that it currently uses the db/core_db functionality for PMT building (required for validation in history network). This module is very much overkill and causes Fluffy to require many parts from nimbus.

This code could be reworked to avoid relying on this nimbus code and for example use the basic PMT implementation with the MemoryDB.
@kdeme kdeme added the Fluffy label Apr 23, 2024
@web3-developer web3-developer self-assigned this Apr 24, 2024
@web3-developer
Copy link
Contributor

Changes implemented here: #2152

@web3-developer
Copy link
Contributor

web3-developer commented May 15, 2024 •
edited

The last references to CoreDb have been removed from the tests in my latest PR here: #2170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@web3-developer web3-developer

Labels
Fluffy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kdeme @web3-developer