Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't accept (many?) concurrent offers for the same content key #1920

Open
kdeme opened this issue Dec 4, 2023 · 1 comment
Open

Don't accept (many?) concurrent offers for the same content key #1920

kdeme opened this issue Dec 4, 2023 · 1 comment
Labels
Fluffy optimization portal-wire Security Security vulnerability or security related

Comments

@kdeme
Copy link
Contributor

kdeme commented Dec 4, 2023

Currently, when an offer comes in, the content key is checked on whether it is inRange and next whether it is not yet in our db.
If both are true, content transfer is accepted. If there are more offers of the same content before it gets transferred, validated & stored in the db, these will also be initiated.

We should cache the content key or content id and verify if no offer/accept is already ongoing for the same content.

One important side node, if the ongoing transfer fails or the content is not valid for some reason, a RFC should be launched for that content so that node can still receive it from another node.
@kdeme kdeme added optimization Fluffy Security Security vulnerability or security related labels Dec 4, 2023
@kdeme
Copy link
Contributor Author

kdeme commented Apr 23, 2024

Related Portal specs issue: ethereum/portal-network-specs#242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fluffy optimization portal-wire Security Security vulnerability or security related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdeme