Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add "disambiguating" select values to scene, gallery, and movie select dropdowns #4790

Closed
echo6ix opened this issue Apr 27, 2024 · 2 comments · Fixed by #4851
Closed

Comments

@echo6ix
Copy link
Contributor

echo6ix commented Apr 27, 2024

Is your feature request related to a problem? Please describe.
Nothing precludes duplicate titles for scene, gallery, or movie objects. Therefore, dropdown select values of each may contain duplicate string values that are impossible to differentiate from one another.

Example of official duplicate gallery titles from ATK
image

This is more prevalent among particular studios that heavily recycle titles, but regardless, given enough content, just as with performer names, duplicates emerge.

Describe the solution you'd like
Display complimentary metadata to disambiguate each select title value in the drop down.

A tiny thumbnail of a cover image may seem irrelevant due to its size, but consider small distinctions in colors and shapes would be enough to disambiguate it from other cover images all other values being equal.

image

Styling should consider the following:

  • Keep height of select consistent with the performer select (Show performer image in select #4227)
  • Title select value should take precedence (ie. white color)
  • Complimentary select values are secondary, and can be conveniently presented below title value with a muted color

For example, something like:

.select-options {

     /* Set default styling for all span elements */
     span {
          color: white;
          display: block;
     }

     span.select-option-title {
     }

     /* Mute text of complimentary metadata span elements */
     span.select-option-date,
     span.select-option-studio_code {
          opacity: 0.7;
     }

}

Additional context
I should have included this broad request in my initial request #3076 (to add performer images to the performer select) implemented here #4227, since it falls under the same conceptual umbrella.

Side note: if studio objects ever have the ability to either use non-unique names or can have favicons, this concept should be applied to them as well since duplicate studio names do exist (outside of Stash).

<select-options>
  <div class="primary line">
        <img>$favicon</img> <span>$studio_name</span>
  </div>
  <div class="secondary line">
        <span>$parent_studios</span>
  </div>
</select-options>
@sleetx
Copy link

sleetx commented May 4, 2024

Nothing precludes duplicate titles for scene, gallery, or movie objects.

Correct for scenes and galleries, but that's not true for movies... I get a "Unique constraint failed" SQL error when attempting to create a Movie with the same title as an existing one.

@echo6ix
Copy link
Contributor Author

echo6ix commented May 4, 2024

Correct for scenes and galleries, but that's not true for movies... I get a "Unique constraint failed" SQL error when attempting to create a Movie with the same title as an existing one.

Thanks for correcting this inaccuracy. I assumed it would allow unique movie titles too, given the volume of duplicate movie titles that exist out there. I suspect this might be addressed when/if movie objects get their eventual refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants