Tracking issue test-external

[theoludwig]

What version of this package are you using?

standard@17.0.0-2

What happened?

test-external is currently failing, before releasing standard@17.0.0 stable we should ensure that the ecosystem is ready.
Here are the failing repos:

• https://github.com/feross/simple-get
• https://github.com/webtorrent/webtorrent
• https://github.com/marcbachmann/node-html-pdf (style: fix new standard linting marcbachmann/node-html-pdf#657)
• https://github.com/jprichardson/electron-mocha (style: fix new standard linting jprichardson/electron-mocha#193)
• https://github.com/feross/chrome-net
• https://github.com/libp2p/js-libp2p-tcp
• https://github.com/feross/safe-buffer
• https://github.com/yargs/yargs-parser
• https://github.com/Level/leveldown (style: fix new standard linting Level/leveldown#800) (they want to merge when standard@17 stable, so we can temporarily disable them for releasing)
• https://github.com/fastify/fastify (style: fix new standard linting fastify/fastify#3682)
• https://github.com/maxogden/extract-zip (style: fix new standard linting max-mapper/extract-zip#128)

[voxpelli]

Are we sure all of these are correct failures? Or are some caused by unintended side-effects?

When I get time to finish #1747 this will be easier to see 🤔

[LinusU]

feross/simple-get#78 would fix simple-get, but it's a breaking change 😅

[theoludwig]

I closed some of my PRs because there are no activities and also because I don't want/have time to do the job for this, feel free to open other PRs to fix the linting issues with standard v17.

[voxpelli]

Caused by switch to eslint-plugin-n

Will need an update once they upgrade, but isn't any actual regression. Action to take: Disable for now

• feross/chrome-net fails due to disabling of node/ rule that needs to be updated to instead disable the n/ rule
• feross/safe-buffer fails due to disabling of node/ rule that needs to be updated to instead disable the n/ rule
• feross/simple-get fails due to disabling of node/ rule that needs to be updated to instead disable the n/ rule
• feross/studynotes.org fails due to disabling of node/ rule that needs to be updated to instead disable the n/ rule
• maxogden/extract-zip fails due to disabling of node/ rule that needs to be updated to instead disable the n/ rule

Caused by eslint 7.19.0

Not blocking eslint-config-standard from going stable at all. Action to take: Disable for now

• webtorrent/webtorrent is caused by eslint 7.19.0, not standard 17, as described in: build(deps): bump eslint from 7.18.0 to 7.32.0 #1702 (comment)
• Level/leveldown is caused by eslint 7.19.0, not standard 17, as described in: build(deps): bump eslint from 7.18.0 to 7.32.0 #1702 (comment)

Causes an error

We should figure out why

• libp2p/js-libp2p-tcp causes an unexpected linter output: Error: All files matched by '.' are ignored. Moved to .ts files which aren't linted by standard and thus causes this failure. Action to take: Remove from list

Causes extra failures

We should check that this isn't an unintended regression

• marcbachmann/node-html-pdf fails on lots of things: no-useless-escape, object-curly-spacing, indent Uses "standard": "^5.1.1", makes no sense to include a package with such an outdated version of standard. Action to take: Disable or remove from list
• yargs/yargs-parser fails in test/yargs-parser.mjs because of: eol-last, no-undef Caused because a lack of linting on their behalf. Opened a PR: Run linting on *.mjs files as well yargs/yargs-parser#439 Action to take: Disable for now, await response on whether they want to be included

[Kdawg5508]

Appreciate your honesty I'll take my business elsewhere. I wasted five months with you all

…

On Wed, Apr 20, 2022, 8:38 AM Divlo ***@***.***> wrote: I closed some of my PRs because there are no activities and also because I don't want/have time to do the job for this, feel free to open other PRs to fix the linting issues with standard v17. — Reply to this email directly, view it on GitHub <#1777 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AV7PVHIX4U7LZMXZQZRTAELVF73CVANCNFSM5NRF57BA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>