Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed examples : batchERC20Transfer & batchTransfer #18

Open
jay0xmo opened this issue Feb 25, 2023 · 0 comments
Open

failed examples : batchERC20Transfer & batchTransfer #18

jay0xmo opened this issue Feb 25, 2023 · 0 comments

Comments

@jay0xmo
Copy link

jay0xmo commented Feb 25, 2023

Thank you for providing various examples, which have been helpful in understanding Abstraction Account. I was able to reproduce other parts successfully, but I am having issues with the implementation of batchERC20Transfer and batchTransfer. When called, I receive the following error message:

{
....
"reason": "Error: VM Exception while processing transaction: reverted with reason string 'account: not Owner or EntryPoint'",
....
}

Upon further investigation, I found that the issue occurs when passing the encodeFunctionData(executeBatch) as a parameter to accountAPI.createSignedUserOp.

const op = await accountAPI.createSignedUserOp({
target: sender,
data: ac.interface.encodeFunctionData("executeBatch", [dest, data]),
...(await getGasFee(provider)),
});
console.log(`Signed UserOperation: ${await printOp(op)}`);

within the implementation of accountAPI, the encodeFunctionData(executeBatch) is re-encoded as execute, and this results in an error when execute is called again within executeBatch.

https://github.com/eth-infinitism/bundler/blob/22166ee14b7ea4d017a365fe36cf9d4a49520e6b/packages/sdk/src/BaseAccountAPI.ts#L169-L188

It seems that a modification to the bundler SDK of eth-infinitism is necessary to support executeBatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant