Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use clar2wasm::compile_contract in clar2wasm::compile #354

Open
Acaccia opened this issue Mar 4, 2024 · 0 comments
Open

Refactor: use clar2wasm::compile_contract in clar2wasm::compile #354

Acaccia opened this issue Mar 4, 2024 · 0 comments
Labels
code quality Improving the quality of the code, and dev experience good first issue Good for newcomers
Milestone

Comments

@Acaccia
Copy link
Collaborator

Acaccia commented Mar 4, 2024

The Clarinet REPL uses clar2wasm::compile_contract in its routine here.

However, There is a fix for some bug that was introduced in clar2wasm::compile here.
Since it was added here, it is not available in the compile_contract function.

I believe those functions should be refactored so that the fix moves to compile_contract (and every future fixes can be added there) and compile should use compile_contract.

@Acaccia Acaccia added good first issue Good for newcomers code quality Improving the quality of the code, and dev experience labels Mar 4, 2024
@smcclellan smcclellan added this to the WASM Phase 3 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improving the quality of the code, and dev experience good first issue Good for newcomers
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

2 participants