Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property tests: ignore generated values if they are too large #320

Open
Acaccia opened this issue Jan 30, 2024 · 1 comment
Open

Property tests: ignore generated values if they are too large #320

Acaccia opened this issue Jan 30, 2024 · 1 comment
Labels
enhancement New feature or request testing
Milestone

Comments

@Acaccia
Copy link
Collaborator

Acaccia commented Jan 30, 2024

When building recursive values, it can happen that a test fails due to the generated value being too large.

There should be a way to use prop_filter to simply ignore those.

@Acaccia Acaccia added enhancement New feature or request testing labels Jan 30, 2024
@moodmosaic
Copy link
Member

Perhaps it would be more efficient to address this issue at the generator/strategy level, rather than relying on prop_filter to discard overly large values.

The concern with using prop_filter for discarding is that it might lead to running the properties fewer times than intended, as it eliminates test cases after they have been generated. This could potentially reduce the thoroughness of the tests. By adjusting the strategy, you can maintain both the efficiency of the test runs and the integrity of the testing process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

3 participants