Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Checking for dangling serviceMonitors #545

Open
abrad3 opened this issue Apr 13, 2023 · 2 comments
Open

[FEATURE_REQUEST] Checking for dangling serviceMonitors #545

abrad3 opened this issue Apr 13, 2023 · 2 comments

Comments

@abrad3
Copy link
Contributor

abrad3 commented Apr 13, 2023

Description of the problem/feature request
A customer asked for me to add a check for dangling serviceMonitors, behaving exactly the same way as the dangling service check.

Description of the existing behavior vs. expected behavior
kubelinter currently does not flag dangling serviceMonitors- i.e. serviceMonitors that do not match any service.
serviceMonitors use the monitoring.coreos.com/v1 apiVersion.
I can provide a full-fledged example of when it should pass or not if necessary.

Additional context
I've implemented this feature already- I'm opening this issue to follow the code of conduct :)
My implementation is at: https://github.com/abrad3/kube-linter/tree/dangling-servicemonitor.

If this sounds good, please let me know and I'll make a PR!

@janisz
Copy link
Collaborator

janisz commented Apr 13, 2023

Sounds good! Waiting for a PR

@abrad3
Copy link
Contributor Author

abrad3 commented Apr 14, 2023

Thanks!
PR: #547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants