Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding ZNode path #799

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Allow overriding ZNode path #799

wants to merge 12 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Apr 4, 2024 •
edited by sbernauer

Description

Fixes #681

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. CRD documentation for all fields, following the style guide.
    Options
  4. Helm chart can be installed and deployed operator works
    Options
  5. Integration tests passed (for non trivial changes)
    Options
  6. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. Code contains useful logging statements
    Options
  3. (Integration-)Test cases added
    Options
  4. Documentation added or updated. Follows the style guide.
    Options
  5. Changelog updated
    Options
  6. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options
  3. Roadmap has been updated
    Options

@nightkr nightkr requested a review from a team April 5, 2024 00:04
@nightkr
Copy link
Member Author

nightkr commented Apr 5, 2024

Some integration tests are currently failing due to a missing spec.image, not sure if it's related to https://stackable-workspace.slack.com/archives/C02M1RE8S0Z/p1712274080585689.

@nightkr
Copy link
Member Author

nightkr commented Apr 26, 2024

Turns out the test failures were due to stale beku work files. Clearing tests/_work made them pass.

@nightkr nightkr marked this pull request as ready for review April 26, 2024 15:39
@sbernauer sbernauer mentioned this pull request May 6, 2024
Open
sbernauer
sbernauer requested changes May 27, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

docs/modules/zookeeper/pages/usage_guide/isolating_clients_with_znodes.adoc
@@ -100,3 +100,20 @@ The Stackable Operators for Kafka and Druid use the discovery ConfigMaps to conn
== What's next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move the newly added stuff above this, so that the "What's next" stays at the very bottom

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, on second thought..

The znode path override is more of an appendix that should really belong in a reference section (or maybe a second guide). It's not part of the regular ZNode workflow that the guide covers primarily.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, would both work for me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth doing a reference for znodes, but are we okay breaking that out of this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely 👍

CHANGELOG.md Outdated Show resolved Hide resolved
deploy/helm/zookeeper-operator/crds/crds.yaml Show resolved Hide resolved
rust/operator-binary/src/znode_controller.rs Show resolved Hide resolved
@sbernauer sbernauer mentioned this pull request May 27, 2024
Open
@nightkr @sbernauer
Update CHANGELOG.md
9767600 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@nightkr nightkr requested a review from sbernauer June 3, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@nightkr nightkr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow k8s administrators to override ZNode path
3 participants
@nightkr @sbernauer @NickLarsenNZ