Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Emit warning when using multiple RoleGroups without a myidOffset #610

Open
fhennig opened this issue Dec 19, 2022 · 2 comments
Labels

Comments

@fhennig
Copy link
Member

fhennig commented Dec 19, 2022

Context

The ZK operator uses the ordinal index of pods in the RoleGroup statefulsets to assign a myid to each replica. This approach leads to duplicate IDs when using more than one RoleGroup, als all indices are 0-based. To prevent ID collisions, a custom myidOffset needs to be specified, for which we wrote documentation.

Improvement

The operator doesn't do anything when there are multiple role-groups without an offset. The operator should at least emit a warning

Reference comment: #546 (comment)

@fhennig
Copy link
Member Author

fhennig commented Dec 19, 2022

Maybe we could even make this an error? I think the operator shouldn't deploy Pods where it knows that ids will conflict. It's easy to track the IDs which are in use.

@lfrancke
Copy link
Member

lfrancke commented Jan 4, 2023

Agreed, this can be caught automatically I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants