Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parentheses in z-score calculation? #203

Open
zhnhou opened this issue Jan 3, 2024 · 0 comments
Open

Missing parentheses in z-score calculation? #203

zhnhou opened this issue Jan 3, 2024 · 0 comments

Comments

@zhnhou
Copy link

zhnhou commented Jan 3, 2024

Noticed this line when enabling z-score calculation for expected rewards. Should it be

if z_score:
    expected_rewards = (
        ( expected_rewards - expected_rewards.mean() ) / expected_rewards.std()
    )

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant