Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] feat: add llrt runtime #3670

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bayssmekanique
Copy link
Contributor

@bayssmekanique bayssmekanique commented Feb 13, 2024

This PR implements the llrm runtime as an experiment.

Current implementation adds support to Function, SsrFunction, SsrSite, and AstroSite constructs.

Resolves #3669

Copy link

changeset-bot bot commented Feb 13, 2024

⚠️ No Changeset found

Latest commit: 4bdba6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bayssmekanique
Copy link
Contributor Author

The runtime currently doesn't support top-level awaits, which is a blocker for the AstroSite support, but there is a possibility of this being resolved soon.

Ref: awslabs/llrt#124

@bayssmekanique
Copy link
Contributor Author

bayssmekanique commented Feb 13, 2024

There is also an issue with the static property on Class definitions that's been reported.

The static init block issue won't be resolved anytime soon, but this should be resolved by forcing to es2020 target once the top level await issue is resolved.

Ref: awslabs/llrt#148

@bayssmekanique
Copy link
Contributor Author

The top level await issue can be resolved now with a plugin to abstract away the await. (Ex: vite-plugin-top-level-await)

The next issue is the number of APIs that aren't natively supported by the runtime and require polyfills. They are not joking when they say it is not a drop-in replacement for node as there is a fairly large number of common utilities which need to be polyfilled.

The Astro web-api was no longer needed and was causing dependency issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow use of LLRT runtime
2 participants