Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next version check #409

Merged
merged 3 commits into from May 12, 2024
Merged

Fix next version check #409

merged 3 commits into from May 12, 2024

Conversation

conico974
Copy link
Collaborator

Fix #406
Instead of checking package.json for next version, we do a require.resolve in the appPath directory to find the package.json of next. Then we require this package and check for the version there.
This should work every time

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: 54579f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
open-next Patch
app-pages-router Patch
app-router Patch
tests-unit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 0:41am

@conico974 conico974 merged commit d5efc43 into sst:main May 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image optimization fails due to version mismatch
2 participants