Cleanup esbuildSync and esbuildAsync

[fwang]

They seem identical. Do we need both?

open-next/packages/open-next/src/build.ts

Lines 763 to 821 in ba84a00

	function esbuildSync(esbuildOptions: ESBuildOptions) {
	const { openNextVersion, debug } = options;
	const result = buildSync({
	target: "esnext",
	format: "esm",
	platform: "node",
	bundle: true,
	minify: debug ? false : true,
	sourcemap: debug ? "inline" : false,
	...esbuildOptions,
	banner: {
	...esbuildOptions.banner,
	js: [
	esbuildOptions.banner?.js || "",
	`globalThis.openNextDebug = ${process.env.OPEN_NEXT_DEBUG ?? false};`,
	`globalThis.openNextVersion = "${openNextVersion}";`,
	].join(""),
	},
	});
	if (result.errors.length > 0) {
	result.errors.forEach((error) => console.error(error));
	throw new Error(
	`There was a problem bundling ${
	(esbuildOptions.entryPoints as string[])[0]
	}.`,
	);
	}
	}
	async function esbuildAsync(esbuildOptions: ESBuildOptions) {
	const { openNextVersion, debug } = options;
	const result = await buildAsync({
	target: "esnext",
	format: "esm",
	platform: "node",
	bundle: true,
	minify: debug ? false : true,
	sourcemap: debug ? "inline" : false,
	...esbuildOptions,
	banner: {
	...esbuildOptions.banner,
	js: [
	esbuildOptions.banner?.js || "",
	`globalThis.openNextDebug = ${process.env.OPEN_NEXT_DEBUG ?? false};`,
	`globalThis.openNextVersion = "${openNextVersion}";`,
	].join(""),
	},
	});
	if (result.errors.length > 0) {
	result.errors.forEach((error) => console.error(error));
	throw new Error(
	`There was a problem bundling ${
	(esbuildOptions.entryPoints as string[])[0]
	}.`,
	);
	}
	}

[khuezy]

we can get rid of the non async one if it doesn't break the build. We had to use async for the plugin system iirc