Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image lambda assets #186

Closed
wants to merge 3 commits into from
Closed

Conversation

edvinerikson
Copy link
Contributor

@edvinerikson edvinerikson commented Aug 25, 2023

Fixes #185
Added a script update-sharp-assets.sh to update the assets automatically

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

⚠️ No Changeset found

Latest commit: bcadc7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 7:29am

@edvinerikson
Copy link
Contributor Author

Note: something isn't right with the dependencies. Since I used linux, the native arm binaries were replaced by linux ones. NOt sure how I can force npm to install arm binaries while still on linux..

@conico974
Copy link
Collaborator

Note: something isn't right with the dependencies. Since I used linux, the native arm binaries were replaced by linux ones. NOt sure how I can force npm to install arm binaries while still on linux..

You could try a command like that npm install --target_arch=arm64 --target_platform=linux or maybe with --arch=arm64 instead. There is not a lot of docs around that.

Anyway, i think it would be a great idea to write a script to automate this process for us in the future. It would also be great to output a single zip file instead of all those files.

@edvinerikson
Copy link
Contributor Author

You could try a command like that npm install --target_arch=arm64 --target_platform=linux or maybe with --arch=arm64 instead. There is not a lot of docs around that.

Thanks, I'll try that!

Anyway, i think it would be a great idea to write a script to automate this process for us in the future. It would also be great to output a single zip file instead of all those files.

I agree, I will try to create a script for it. However I will wait with the zipfile since that is a breaking change

@sladg
Copy link
Contributor

sladg commented Aug 25, 2023

forcing arm/amd from other platform is virtually impossible with node currently 😢 I guess that's the reason these were committed and part of repo in a first place. We might want to run these in pipelines in Github or make script for running this in docker in given platform

@sladg
Copy link
Contributor

sladg commented Aug 25, 2023

Related to #184

@edvinerikson
Copy link
Contributor Author

forcing arm/amd from other platform is virtually impossible with node currently 😢 I guess that's the reason these were committed and part of repo in a first place. We might want to run these in pipelines in Github or make script for running this in docker in given platform

--arch=arm64 seems to have made a difference at least. Now there's linuxarm64 binaries instead of linuxamd.

@conico974
Copy link
Collaborator

conico974 commented Aug 25, 2023

I agree, I will try to create a script for it. However I will wait with the zipfile since that is a breaking change

The bundling is done here

function createImageOptimizationBundle() {
You could unzip at this time

@sladg sladg mentioned this pull request Aug 27, 2023
@edvinerikson edvinerikson deleted the update-assets branch August 28, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update semver in bundled image lambda assets
3 participants