Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/Paste mistake in radio uhd driver? #390

Open
FredNys opened this issue Jan 3, 2024 · 0 comments
Open

Copy/Paste mistake in radio uhd driver? #390

FredNys opened this issue Jan 3, 2024 · 0 comments
Assignees

Comments

@FredNys
Copy link

FredNys commented Jan 3, 2024

in radio_uhd_impl.cpp, line 240, total_tx_channel_count is set based on rx stream instead tx stream. Is it on purpose or copy/paste mistake?

unsigned total_rx_channel_count = 0;
for (const radio_configuration::stream& stream_config : radio_config.rx_streams) {
total_rx_channel_count += stream_config.channels.size();
}

unsigned total_tx_channel_count = 0;
for (const radio_configuration::stream& stream_config : radio_config.rx_streams) { // SHOULDN'T IT BE TX_STREAMS ?
total_tx_channel_count += stream_config.channels.size();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants